Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of MISE middleware #4070

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implementation of MISE middleware #4070

wants to merge 4 commits into from

Conversation

sankur-codes
Copy link
Collaborator

@sankur-codes sankur-codes commented Jan 30, 2025 •
edited
Loading

Which issue this PR addresses:

Fixes ARO-5946. Updated PR for #3555

What this PR does / why we need it:

This PR integrates MISE authentication for our RP to improve security while keeping existing certificate based authentication as a fallback.

Test plan for issue:

Unit tests are included. Testing has been done on dev and proceeding to Canary.

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

Been tested on INT and in being tested on Canary as well with expected results.

@sankur-codes sankur-codes mentioned this pull request Jan 30, 2025
Closed
@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jan 30, 2025
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@sankur-codes sankur-codes force-pushed the sankur-codes/ARO-5946-MISE branch from 0321d96 to b43d743 Compare February 10, 2025 09:08
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Feb 10, 2025
@sankur-codes sankur-codes force-pushed the sankur-codes/ARO-5946-MISE branch 5 times, most recently from 6b53531 to 0a7770e Compare February 14, 2025 03:35
@sankur-codes sankur-codes force-pushed the sankur-codes/ARO-5946-MISE branch 4 times, most recently from 645f5cf to 5f9ebee Compare February 14, 2025 12:15
@sankur-codes sankur-codes added ready-for-review firefly Issues or Pull requests owned by Team Firefly labels Feb 14, 2025
@github-actions github-actions bot added needs-rebase branch needs a rebase and removed ready-for-review labels Feb 14, 2025
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@sankur-codes sankur-codes force-pushed the sankur-codes/ARO-5946-MISE branch from 5f9ebee to 91eebeb Compare February 15, 2025 09:54
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Feb 15, 2025
@sankur-codes sankur-codes added ready-for-review priority-high High priority issue or pull request go Pull requests that update Go code labels Feb 15, 2025
@sankur-codes sankur-codes force-pushed the sankur-codes/ARO-5946-MISE branch from f28281d to cd10539 Compare February 15, 2025 12:03
@sankur-codes sankur-codes force-pushed the sankur-codes/ARO-5946-MISE branch from cd10539 to c7b1858 Compare February 15, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@kimorris27 kimorris27 Awaiting requested review from kimorris27 kimorris27 is a code owner

@tsatam tsatam Awaiting requested review from tsatam tsatam is a code owner

@bitoku bitoku Awaiting requested review from bitoku bitoku is a code owner

@fahlmant fahlmant Awaiting requested review from fahlmant fahlmant is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
firefly Issues or Pull requests owned by Team Firefly go Pull requests that update Go code priority-high High priority issue or pull request ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sankur-codes